Rank: Member
Joined: 4/29/2010(UTC)
Posts: 256
Thanks: 4 times
Was thanked: 11 time(s) in 10 post(s)
|
Aaron
I am not sure when the next release of BV Commerce is, but would it be possible to change a few of the methods within the core?
For instance if you create a project which references the BVSoftware.Bvc5.Core you may wish to return some of the data as an order object etc?
is there any chance that functions such as
Private Shared Function ConvertDataRow(ByVal dr As DataRow) As Orders.Order
to
Protected Shared Function ConvertDataRow(ByVal dr As DataRow) As Orders.Order
so that inherited/extended class can access those methods?
|
|
|
|
|
|
Rank: Administration
Joined: 4/2/2004(UTC) Posts: 2,395 ![United States]( "United States") Location: Hummelstown, PA Thanks: 6 times
Was thanked: 163 time(s) in 158 post(s)
|
We've run into this when we built plugins. Our "workaround", if you could call it that, was to create a copy of the function within our plugin. Not very elegant...
In the case of the Orders object, setting the ConvertDataRow function to Protected won't help because the Mapper class that contains it is Private. Even if we set that class to Protected there are plenty of cases where you might want to convert a DataRow into an Order object. It almost seems like the ConvertDataRow functions should be publically accessible. Thoughts? |
Aaron Sherrick
BV Commerce
Toll-free 888-665-8637 - Int'l +1 717-220-0012 |
|
|
|
|
|
Rank: Member
Joined: 4/29/2010(UTC)
Posts: 256
Thanks: 4 times
Was thanked: 11 time(s) in 10 post(s)
|
I didn't drill down to much into the core, but anything which can transform a Datarow into an object/entity would be helpful. I suppose it depends upon how much effort it would take to refactor the code and test it. Even better if it could be seperate library from the core, however I suspect that that might be too time consuming.
As for the copy and pasting that is what I am currently doing. It just seems a shame from an ideal coding point of view when you are extending/inheriting the class.
|
|
|
|
|
|
Forum Jump
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.