Rank: Member
Joined: 11/18/2003(UTC)
Posts: 1,465
|
I noticed that the Product Templates (such as BVC5 and BVC2004) reference a Master Page File in the Themes BVC5 folder directly:
MasterPageFile="~/BVModules/Themes/Bvc5/Product.master"
I would assume this means that any changes done on a new theme Master Page for Product.master will never be reflected on the product info page. So if this is true then along with any new template someone makes they may need to create a new Product Template that directly reference their Theme folder.
Am I missing something? |
TIM
BVC Add-Ons and Development |
|
|
|
|
|
Rank: Member
Joined: 1/3/2004(UTC)
Posts: 1,497
|
You missed the code in product.aspx.vb under each producttemplate. Look at the Page_PreInit sub. It modifies the MasterPageFile to the theme you are using. |
|
|
|
|
|
|
Rank: Member
Joined: 11/18/2003(UTC)
Posts: 1,465
|
OK I see that, but this doesn't allow you to visually see the page layout in Design mode of VS because it reference the BVC5 theme folder. You would need to hand edit this to point to your theme folder in order to work visually in VS. The other problem I can see happening is users deleting the BVC5 theme folder when using their own. It might be better for default references to go to the root of themes or some other folder than a stock theme. |
TIM
BVC Add-Ons and Development |
|
|
|
|
|
Rank: Member
Joined: 5/24/2004(UTC)
Posts: 4,147
|
Because it's all dynamic, I don't see a way around that except to manually edit that dummy link in the module. That, or don't use the Design View (I don't trust it anyway, and it slows down the process). |
|
|
|
|
|
|
Rank: Member
Joined: 11/18/2003(UTC)
Posts: 1,465
|
Yeah visually it's not great in VS but sometimes it can help to visualize some of your source edits quickly. It's really not a big deal to edit this, just something that I wanted to bring up. I usually blow out any themes I'm not using and since BVC5 default theme will not be used by many it stands a good change of being deleted. I haven't tried a test yet but I imagine this could break things. |
TIM
BVC Add-Ons and Development |
|
|
|
|
|
Rank: Member
Joined: 5/24/2004(UTC)
Posts: 4,147
|
Yeah, I haven't had a chance to test that either, but since the real stuff is in the code-behind, changing that path - if just temporarily - shouldn't break anything. I'm no developer, so let us know if you get a chance to mess with it. ;) |
|
|
|
|
|
|
Rank: Member
Joined: 1/3/2004(UTC)
Posts: 1,497
|
So when Cliff release FreshStart theme for BVC5, we can all point to that theme as the default one! |
|
|
|
|
|
|
Rank: Member
Joined: 5/24/2004(UTC)
Posts: 4,147
|
Hah. Oh, the pressure is on... |
|
|
|
|
|
|
Forum Jump
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.