The Shipping Changed workflow starts off with the "Mark Completed When Order Is Shipped And Paid" task. But this task does not recalculate the shipping status. It seems like the task should either be changed to calculate the status by running context.Order.EvaluateShippingStatus, or a new task should be created and inserted at the top of the workflow that evaluates the shipping status.


The same comments apply to the Payment Changed workflow.

Yes, exactly.

First attempt:

1) pull the order, 2) ship a package, 3) run the "Shipping Changed" workflow.

Since I am passing the order pulled in step 1 in the workflow context, the ShippingStatus is old, so the workflow does not mark the order complete.

Second attempt:

1) pull the order, 2) ship a package, 3) pull the order, 4) run the "Shipping Changed" workflow.

This works because the order that I pass into the workflow has updated ShippingStatus.

Third attempt:

1) pull the order, 2) ship a package, 3) mark the items shipped manually to match what package.Ship did, 4) set order.ShippingStatus = Orders_Order_EvaluateShippingStatus(), 5) run the "Shipping Changed" workflow.

This also works, but I want to avoid #3; and #4 has just as much overhead as retrieving a new copy of the order so I am going to stick with the second attempt. In which case there is no point to changing the workflow task that you wrote.