Rank: Member
Joined: 10/17/2006(UTC)
Posts: 66
|
It seems like several pages that I have run into do a poor job of error handling. Let's say that the user clicks a button. An internal error occurs, and an error gets written to the event log (which is nice). But the user sees no message (at least it's not very consistent). An example is the click handler in Checkout.aspx of the Paypal Express checkout: Code:
If BusinessRules.Workflow.RunByName(c, "Process New Order") Then
SessionManager.CurrentCartID = String.Empty
Response.Redirect("~/Receipt.aspx?id=" & Basket.Bvin)
Else
' Show Errors
For Each item As BusinessRules.WorkflowMessage In c.GetCustomerVisibleErrors
Me.lblErrors.Text += item.Description & "<br />"
Next
End If
If an error happens, the user is left on the same page. No message. I've seen this a few times. My suggestion: EVERY PAGE should have a place to display error messages. The Message1 label control that is on most pages is might be enhanced to be a new control called BVErrorMessage (put it on the master). This would have two benefits: 1) The look/feel of the error display could be enhanced in one place. 2) The control could be responsible for writing to the event log for critical messages (reduce the duplication of messages).
|
|
|
|
|
|
Rank: Member
Joined: 10/17/2006(UTC)
Posts: 66
|
Heh. The posted code was kindof a counter example :)
I guess I'm not sure why it happens, but in the PAYPAL code especially, I rarely see messges on the screen when paypal failures occur. But the log is full of them. I'd like my users to know that something has gone wrong.
-- Jorge.
|
|
|
|
|
|
Forum Jump
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.